cmd/geth: add check func to validate state scheme #2067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sysvm
force-pushed
the
fix-pbssconfig
branch
from
50c4e45
to
f2dc7a5
Compare
joeylichang
previously approved these changes
Dec 14, 2023
|
LGTM |
sysvm
force-pushed
the
fix-pbssconfig
branch
from
f2dc7a5
to
e1aae7b
Compare
flywukong
reviewed
Dec 14, 2023
| // there is no persistent state data in disk db(e.g. geth init) | ||
| if !ctx.IsSet(StateSchemeFlag.Name) { | ||
| log.Info("State scheme set by config", "scheme", stateSchemeCfg) | ||
| return stateSchemeCfg, nil |
There was a problem hiding this comment.
need judge if the stateSchemeCfg is not setted
There was a problem hiding this comment.
stateSchemeCfg is impossible to be empty in ResolveStateScheme function, because there is a default value in caller function loadBaseConfig.
flywukong
reviewed
Dec 14, 2023
| } | ||
| if !ctx.IsSet(StateSchemeFlag.Name) { | ||
| if stored != stateSchemeCfg { | ||
| return "", fmt.Errorf("incompatible state scheme, stored: %s, config: %s", stored, stateSchemeCfg) |
There was a problem hiding this comment.
should not return error if stateSchemeCfg is empty
There was a problem hiding this comment.
ditto. stateSchemeCfg is impossible to be empty in ResolveStateScheme function.
flywukong
previously approved these changes
Dec 15, 2023
This was referenced Dec 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide explicit for which state scheme geth can use to start or init. And add check function to validate provided state scheme.
Rationale
Users may add
StateScheme = "path"inconfig.tomland want to start geth without persistent state in disk, but geth is started inhashmode. For solving these cases, add a function, obey the following rules:Example
nohup ./geth --config config.toml --cache 8000 --rpc.allow-unprotected-txs --history.transactions 0 >> nohup.out 2>&1&and addStateScheme = "path"inconfig.toml, geth is started inpathmode.Changes
Notable changes: