Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default hardfork times #2058

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Dec 12, 2023

Description

Set default hardfork times

Rationale

hardfork transit to time based from shanghai

we should set default values for time based hardforks as we have done for block based hardforks.

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 force-pushed the set_default_hardfork_times branch 3 times, most recently from 54b4fa6 to 1772c96 Compare December 12, 2023 10:44
core/genesis.go Outdated Show resolved Hide resolved
Mister-EA
Mister-EA previously approved these changes Dec 12, 2023
@buddh0
Copy link
Collaborator Author

buddh0 commented Dec 13, 2023

have test locally,steps:
image

  1. set a cluster with a genesis.json, but ShanghaiTime and KeplerTime not set
  2. modify ChapelGenesisHash of bsc client to genesishash of the above cluster
  3. restart bsc, and found that ShanghaiTime and KeplerTime have been set successfully

@buddh0 buddh0 merged commit 1ebf2a4 into bnb-chain:develop Dec 13, 2023
5 checks passed
@buddh0 buddh0 deleted the set_default_hardfork_times branch December 22, 2023 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants