Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd, core, eth: change default network from ETH to BSC #2015

Merged
merged 2 commits into from
Dec 14, 2023
Merged

cmd, core, eth: change default network from ETH to BSC #2015

merged 2 commits into from
Dec 14, 2023

Conversation

weiihann
Copy link
Contributor

@weiihann weiihann commented Nov 29, 2023 •
edited
Loading

Description

Users can now start nodes on BSC mainnet without relying on geth init genesis.json.

Rationale

Example

./bsc --datadir node

Output:

INFO [11-29|15:06:35.973] Starting Geth on BSC mainnet...
...
INFO [11-29|15:06:36.546] Initialising Ethereum protocol           network=56 dbversion=8
INFO [11-29|15:06:36.546] Initialised chain configuration          config="{ChainID: 56 Homestead: 0 DAO: <nil> DAOSupport: false EIP150: 0 EIP155: 0 EIP158: 0 Byzantium: 0 Constantinople: 0 Petersburg: 0 Istanbul: 0, Muir Glacier: 0, Ramanujan: 0, Niels: 0, MirrorSync: 5184000, Bruno: 13082000, Berlin: 31302048, YOLO v3: <nil>, CatalystBlock: <nil>, London: 31302048, ArrowGlacier: <nil>, MergeFork:<nil>, Euler: 18907621, Gibbs: 23846001, Nano: 21962149, Moran: 22107423, Planck: 27281024,Luban: 29020050, Plato: 30720096, Hertz: 31302048, ShanghaiTime: <nil>, KeplerTime: <nil>, Engine: parlia}"
INFO [11-29|15:06:36.612] Loaded most recent local block           number=25536 hash=974a38..34d654 root=6489e2..036b79 td=50930 age=3y3mo2w
INFO [11-29|15:06:36.613] Loaded most recent local finalized block number=0     hash=0d2184..d57b5b root=919fcc..03b422 td=1     age=3y7mo3w
...
INFO [11-29|15:06:40.041] Block synchronisation started

Changes

  • remove ETH main net flag
  • add BSC genesis block data

@karalabe @weiihann
cmd, core, params: add support for the Holesky testnet (#28007)
56fc35f 
* cmd, core, params: add support for the Holesky testnet

* cmd/devp2p: add support for holesky for the dns crawler
# Conflicts:
#	cmd/devp2p/nodesetcmd.go
#	cmd/geth/main.go
#	cmd/utils/flags.go
#	core/genesis.go
#	params/bootnodes.go
#	params/config.go
@zzzckck zzzckck merged commit 84b268f into bnb-chain:develop Dec 14, 2023
5 checks passed
This was referenced Dec 14, 2023
Merged
Merged
@buddh0 buddh0 mentioned this pull request Dec 22, 2023
Merged
@buddh0 buddh0 mentioned this pull request Jan 4, 2024
Merged
@Kingcrypto38 Kingcrypto38 mentioned this pull request Jan 11, 2024
Open
@weiihann weiihann deleted the tidy-up branch March 13, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buddh0 buddh0 buddh0 approved these changes

@zzzckck zzzckck zzzckck approved these changes

@brilliant-lx brilliant-lx Awaiting requested review from brilliant-lx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weiihann @buddh0 @zzzckck @karalabe