Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus/parlia: recover faster when snapshot of parlia is gone in disk #2008

Merged

Conversation

buddh0
Copy link
Collaborator

@buddh0 buddh0 commented Nov 28, 2023

Description

consensus/parlia: recover faster when snapshot of parlia is gone in disk

Rationale

snapshots of parlia will be stored into disk every 1024 blocks.

if they are missing, just create a new one before reaching FullImmutabilityThreshold

for bsc, 15 blocks is usually view as the probabilistic fanlity number.

FullImmutabilityThreshold is 90000, too large,

so only in this case , we decrease ti by 10 times to 9000

Example

add an example CLI or API response...

Changes

Notable changes:

  • add each change in a bullet point here
  • ...

@buddh0 buddh0 changed the base branch from master to develop November 28, 2023 03:17
@buddh0 buddh0 changed the title Recover faster when snapshot gone consensus/parlia: recover faster when snapshot of parlia is gone in disk Nov 28, 2023
@buddh0 buddh0 force-pushed the recover_faster_when_snapshot_gone branch from be80779 to a6f3393 Compare November 28, 2023 03:26
@brilliant-lx brilliant-lx merged commit 1edb34f into bnb-chain:develop Nov 28, 2023
5 checks passed
weiihann pushed a commit to weiihann/bsc that referenced this pull request Dec 5, 2023
@buddh0 buddh0 deleted the recover_faster_when_snapshot_gone branch December 12, 2023 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants