fix: v1.3.1-beta cannot start with --pruneancient=true
#1986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zlacfzy
approved these changes
Nov 14, 2023
buddh0
approved these changes
Nov 14, 2023
This was referenced Nov 22, 2023
flywukong
pushed a commit
to flywukong/bsc
that referenced
this pull request
Nov 22, 2023
brilliant-lx
pushed a commit
that referenced
this pull request
Nov 30, 2023
|
i got this issue also |
brilliant-lx
pushed a commit
that referenced
this pull request
Dec 4, 2023
weiihann
added a commit
to weiihann/bsc
that referenced
this pull request
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the node unable to start issue if
--pruneancient=trueby creating a non-read-only database.Refer to #1984 and #1982.
Rationale
When initializing a readonly database, it will attempt to open a freezer file for read only (refer to code here). Since ancient files are pruned and no longer exist, the read file operation will fail and return error.
Example
Refer to #1984 and #1982.
Changes
Create a non-read-only database if
--pruneancient=true.