internal/ethapi: fix null effectiveGasPrice in GetTransactionReceipt #1980
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2082,6 +2091,9 @@ func (bc *BlockChain) insertChain(chain types.Blocks, setHead bool) (int, error) | |||
| if err != nil { | |||
| return it.index, err | |||
| } | |||
|
|
|||
| bc.cacheReceipts(block.Hash(), receipts, block) | |||
There was a problem hiding this comment.
Why this line's positioning was changed?
There was a problem hiding this comment.
no need to store the field EffectiveGasPrice to disk
because it can be derived from transaction info, please refer to func ReadReceipts-->func DeriveFields
so we move the cache action after func WriteReceipts
galaio
approved these changes
Nov 13, 2023
brilliant-lx
approved these changes
Nov 14, 2023
weiihann
pushed a commit
to weiihann/bsc
that referenced
this pull request
Dec 5, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
internal/ethapi: fix null effectiveGasPrice in GetTransactionReceipt
Rationale
cached receipt miss the
fieldeffectiveGasPrice, fix itExample
add an example CLI or API response...
Changes
Notable changes: