fix: upgrade pebble and improve config #1979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flywukong
force-pushed
the
fix-upgrade-pebble
branch
2 times, most recently
from
8e44eb4
to
a49b2fe
Compare
sysvm
reviewed
Nov 10, 2023
RenRick
previously approved these changes
Nov 10, 2023
flywukong
force-pushed
the
fix-upgrade-pebble
branch
from
ea99ea4
to
f702aed
Compare
fynnss
approved these changes
Nov 20, 2023
joeylichang
approved these changes
Nov 20, 2023
joeylichang
pushed a commit
to joeylichang/bsc
that referenced
this pull request
Dec 1, 2023
joeylichang
pushed a commit
to joeylichang/bsc
that referenced
this pull request
Dec 1, 2023
fynnss
pushed a commit
to fynnss/bsc
that referenced
this pull request
Dec 4, 2023
weiihann
pushed a commit
to weiihann/bsc
that referenced
this pull request
Dec 5, 2023
This was referenced Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Rationale
the block chasing performance of the geth with pebble （after upgrade） is not bad than leveldb, so it is suitable as an alternative to leveldb
the yellow one is leveldb , pebble avg: 371ms (avg value of 24 hours), leveldb avg: 380ms (avg value of 24 hours)
Example
add an example CLI or API response...
Changes
Notable changes: