eth, trie/triedb/pathdb: pbss patches #1955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeylichang
force-pushed
the
pbss_fix
branch
4 times, most recently
from
d8a631f
to
cea8fa4
Compare
fynnss
reviewed
Nov 1, 2023
fynnss
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
NathanBSC
reviewed
Nov 1, 2023
|
1.DefaultDirtyBufferSize 64MB, it is conflicted with the current cache allocation, which allocate 25% cache to dirty cache by default. |
NathanBSC
reviewed
Nov 3, 2023
PBSS nodebuffer will aggregate the nodes of multiple difflayers together, so the nodebuffer will be written in one batch, so it should not be too large. MaxDirtyBufferSize and DefaultDirtyBufferSize are both verified and considered values. |
joeylichang
force-pushed
the
pbss_fix
branch
3 times, most recently
from
4c80518
to
becbe8f
Compare
buddh0
approved these changes
Nov 6, 2023
fynnss
approved these changes
Nov 6, 2023
buddh0
added
duplicate
Merged
whw188
pushed a commit
to tylerteea/mev-bsc
that referenced
this pull request
Dec 6, 2023
* fix: use the top root hash for rewinding under path schema * feat: add async flush nodebuffer in path schema * chore: add prun-block param suffix check * fix: code review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the stability and performance of PBSS, opt the add asyncnodebuffer option for flushing disk(it non-block state commit), fix rewind root hash mismatch.
Rationale
Example
--pathdb.syncuse the origin nodebuffer, the defaulte use the asyncnodebuffer.Changes
Notable changes: