txpool: fix a potential crash issue in shutdown; #1951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buddh0
approved these changes
Oct 30, 2023
zlacfzy
approved these changes
Oct 30, 2023
brilliant-lx
approved these changes
Oct 30, 2023
brilliant-lx
pushed a commit
that referenced
this pull request
Oct 31, 2023
Merged
whw188
pushed a commit
to tylerteea/mev-bsc
that referenced
this pull request
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr is a fix for issue #1942, when shutdown txpool, it will return nil instance, this fix will ignore them.
Changes
Notable changes: