dependency: go version to 1.20 and some dependencies in go.mod #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilliant-lx
changed the title
brilliant-lx
changed the title
brilliant-lx
changed the title
prysm from v4.0.2 to v4.0.8, and run go mod tidy
there is some dependency on go v1.20, such as go-libp2p v0.27.8 and also run go mod tidy
it is not a big issue, since docker is only used for test purpose.
brilliant-lx
force-pushed
the
go_mod_prysm
branch
from
a2fc38e
to
20d8823
Compare
|
fail to compile with [email protected] and in ./accounts/abi/bind/bind_test.go, |
2 APIs of math/rand module were deprecated since golang v1.20. that is: rand.Seed() and rand.Read(), refer: ettps:https://pkg.go.dev/math/rand "rand.Seed(seed int64)" has been replaced by: "r := rand.New(rand.NewSource(seed int64))", need to initialize it with an instance before use "rand.Read()" has been replaced by "crypto/rand.Read()"
brilliant-lx
force-pushed
the
go_mod_prysm
branch
from
df73116
to
32bc485
Compare
brilliant-lx
force-pushed
the
go_mod_prysm
branch
from
4bdb15c
to
c5f6ccc
Compare
buddh0
approved these changes
Oct 24, 2023
Mister-EA
approved these changes
Oct 24, 2023
Merged
whw188
pushed a commit
to tylerteea/mev-bsc
that referenced
this pull request
Dec 6, 2023
…hain#1939) * go.mod: upgrade prysm and the indrect dependency prysm from v4.0.2 to v4.0.8, and run go mod tidy * ci: upgrade go version from 1.19 to 1.20 * go-version: upgrade from v1.19 to v1.20 there is some dependency on go v1.20, such as go-libp2p v0.27.8 and also run go mod tidy * dependency: upgrade docker version for security it is not a big issue, since docker is only used for test purpose. * rand: update the usage of math/rand after golang v1.20 2 APIs of math/rand module were deprecated since golang v1.20. that is: rand.Seed() and rand.Read(), refer: ettps:https://pkg.go.dev/math/rand "rand.Seed(seed int64)" has been replaced by: "r := rand.New(rand.NewSource(seed int64))", need to initialize it with an instance before use "rand.Read()" has been replaced by "crypto/rand.Read()" * readme: need golang v1.20+ to build bsc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
upgrade some dependencies for quality enhancement.
It is mainly for go-libp2p upgrade, which has a potential OOM risk. go-libp2p was added by prysm indirectly, so upgrade prysm instead. It will also upgrade go-libp2p to v0.27.8 and it needs golang v1.20+ to compile, but prsym v4.0.8 can not be compiled with golang v1.21. So only upgrade to v1.20.
actually it is not an issue for BSC, since BSC only use it for test purpose, but upgrade also is ok.
And after golang v1.20, the usage of math/rand module has been changed, see: https://pkg.go.dev/math/rand
Rationale
Example
NA
Changes
NA