release: prepare for release v1.2.6 #1697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brilliant-lx
force-pushed
the
preare_v1.2.6
branch
2 times, most recently
from
1fac675
to
527d1de
Compare
brilliant-lx
force-pushed
the
preare_v1.2.6
branch
from
527d1de
to
63aa67e
Compare
Mister-EA
reviewed
Jun 15, 2023
| } | ||
|
|
||
| func TestSstoreGasPreEIP3529(t *testing.T) { | ||
| func TestSstoreModifyGasPreLondon(t *testing.T) { |
There was a problem hiding this comment.
This code is already on develop. I don't understand why Github is showing this as new addition.
There was a problem hiding this comment.
yea, you are right, I updated my branch. now it is ok.
brilliant-lx
force-pushed
the
preare_v1.2.6
branch
from
63aa67e
to
93f71c8
Compare
Mister-EA
approved these changes
Jun 15, 2023
buddh0
approved these changes
Jun 15, 2023
This was referenced Jun 15, 2023
|
If I keep that, I'm sure it will figure it out. John Miller |
There was a problem hiding this comment.
If I can never figure it out, I will have just seen it in my email address John's last [email protected]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
update: v1.2.6 is replaced by v1.2.7, since a desired change will be included in hertz hard fork.
The testnet is expected to have a scheduled hardfork upgrade named
Hertz(London&Berlin)at block height 31,103,030. The current block generation speed forecasts this to occur around 29th Jun 2023.The
Hertzhardfork will port some ofLondon&Berlinupgrades from Ethereum to BSC for compatiblity. But due to the difference between the 2 networks, there would inevitably has difference in implementation, especially the different in EIP-1559, the BaseFee will be zero on BSC, so this hard fork will not introduce new burn mechanism neither the concept of GasTip. In short words, it only provides the interface, but actually no change to the current BSC Gas mechanism.Here is the list of
Hertzupgrade:Berlin Upgrades Ported:
a.BEP-225: Implement EIP-2565 ModExp Gas Cost
b.BEP-229: Implement EIP-2718 Typed Transaction Envelope
c.BEP-230: Implement EIP-2929 Gas cost increases for state access opcodes
d.BEP-231: Implement EIP-2930: Optional access lists
London Upgrades Ported:
a.BEP-227: Implement EIP-3198: BASEFEE opcode
b.BEP-226: Implement EIP-1559 with base fee of 0
c.BEP-228: Implement EIP-3541: Prevent deploying contracts starting with 0xEF
d.BEP-212: Implement EIP-3529: Reduction in Refunds
The validators and full node operators on testnet should switch their software version to v1.2.6 before 29th Jun 2023.
Rationale
FEATURE
IMPROVEMENT
BUGFIX
Example
None