Parlia: Some updates of the miner worker #1182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some update of the worker.go
1.Delay() with DelayLeftOver
Right now, DelayLeftOver is used to reserve time for block finalize, not block broadcast.
The general block generation could be described as:
|- fillTransactions -|- finalize a block -|- wait until the period(3s) reached -|- broadcast -|
And the code does not work as expected, some code improve on the Delay() logic.
2.no need to add transaction to the current work if mining is stopped.
It seems that it is unnecessary to add transaction when mining is stopped.
It is a old logic of PoW, which is no longer need for BSC.
Rationale
none
Example
none
Changes
none