[R4R]fix: resolve the concurrent cache read and write issue for fast node #1009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: cryyl <[email protected]>
unclezoro
changed the title
unclezoro
previously approved these changes
Jul 21, 2022
|
LGTM |
unclezoro
force-pushed
the
fix_cache_concurrency
branch
from
8288715
to
287677a
Compare
unclezoro
approved these changes
Jul 22, 2022
forcodedancing
approved these changes
Jul 22, 2022
yutianwu
approved these changes
Jul 22, 2022
j75689
approved these changes
Jul 22, 2022
This was referenced Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: cryyl [email protected]
Description
When fast node insert a block, it will judge whether the 11 ahead of current block has been verified. While, if a block is an empty block, it must be verified. So if the 11 ahead block is an empty block, the AncestorVerified function will return true.
Rationale
Example
Changes
Notable changes: