[R4R] Fix pipecommit active statedb #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinglin89
changed the title
brilliant-lx
changed the title
unclezoro
reviewed
Jul 19, 2022
| if s.prefetcher != nil && len(addressesToPrefetch) > 0 { | ||
| s.prefetcher.prefetch(s.originalRoot, addressesToPrefetch, emptyAddr) | ||
| prefetcher := s.prefetcher | ||
| if prefetcher != nil && len(addressesToPrefetch) > 0 { |
There was a problem hiding this comment.
can you add some UTs to battle test the concurrence issue of statedb?
There was a problem hiding this comment.
pointer assignment is actually atomic, but would fail race detection.
qinglin89
force-pushed
the
fixpipecommitonActiveStatedb
branch
from
e3fce87
to
ec28650
Compare
qinglin89
force-pushed
the
fixpipecommitonActiveStatedb
branch
from
ec28650
to
9e53b1d
Compare
unclezoro
previously approved these changes
Jul 20, 2022
forcodedancing
previously approved these changes
Jul 20, 2022
qinglin89
dismissed stale reviews from forcodedancing, unclezoro, and brilliant-lx
via
4d92fd7
qinglin89
force-pushed
the
fixpipecommitonActiveStatedb
branch
from
9e53b1d
to
4d92fd7
Compare
forcodedancing
approved these changes
Jul 26, 2022
unclezoro
approved these changes
Jul 26, 2022
This was referenced Jul 28, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
prefetcherbe accessed after non-nil condition as a field ofstatedbis not safe.eg: as in
pipecommitmode,statedbmight be used asactivestatedbtoStopPrefetcher, which wouldpanicduring:Rationale
get
prefetcherfromstatedbbefore check nil conditionExample
N/A
Changes