-
Notifications
You must be signed in to change notification settings - Fork 550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BEP1&2 proposals #1
Conversation
c8651eb
to
138b484
Compare
Why does BEP2 use signed integers for amount and supply? |
| :------------ | :-------- | :------------------------------------------------------------ | | ||
| Name | string | Name of the newly issued asset, limited to 32 unicode characters, e.g. "ABCcoin" | | ||
| Symbol | string | The length of the string for representing this asset is between 3 and 8 alphanumeric characters and is case insensitive. ".B" suffixed symbol is also allowed for pegging to those tokens already exist on other chains. The symbol is suffixed with the first 3 bytes of the issue transaction hash to remove a constraint of requiring unique token names. The native token, BNB, does not require this suffix. | | ||
| Total Supply | int64 | The total supply for this token can have a maximum of 8 digits of decimal and is boosted by 1e8 in order to store as int64. The amount before boosting should not exceed 90 billion. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is there an artificial supply cap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, the cap is similar to the amount possible when subdividing by 1e8. The real limit is ~92.23372 Billion.
You should probably increase the number of bits to 128 or 256 from 63. |
The supply constraint is crippling. Edit: I'm now confident I misunderstood the 1e8 modifier; it seemed to be the modulo for mints and redemptions. The limit is 100x higher than previously asserted, but still far too low. |
Update BEP-174 with newer function changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😀
In this PR, BEP 1&2 were added.
BEP1 is the general guideline and BEP2 is about tokens on Binance Chain.