Fixing high-dimensional resampling #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 83.49% 82.60% -0.89%
==========================================
Files 4 4
Lines 103 92 -11
==========================================
- Hits 86 76 -10
+ Misses 17 16 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should resolve #73 , and provides a few other simplifications and cleanups within the code algorithm.
It bumps the minimal numpy to 1.17 (for improved zeros_like behavior) and numba to 0.41 (mainly due to availability on conda-forge).
It also adds a minimal CI environment for our oldest dependency versions. In setting this up, I realized that we don't really need scipy at runtime, so I've made it a test-only dependency. This isn't a huge change (default filter is now Hann instead of Blackman-Harris; the default is not used by the user-facing API though), and I expect that anyone using resampy will have scipy anyway. The reason to drop it as a dependency is that it simplifies our minimal version spec.