Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for geojson format url #73

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shivamSspirit
Copy link

add support for geoJSON file format

@netlify
Copy link

netlify bot commented Nov 10, 2021

👷 Deploy request for raster-playground pending review.
Visit the deploys page to approve it

🔨 Explore the source changes: aa98a16

@shivamSspirit
Copy link
Author

leave feedback so i can improve as soon as possible

Comment on lines 11 to 13
function get_url_extension(url) {
return url.split(/[#?]/)[0].split('.').pop().trim();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if data comes from non-extension API?
I think some other approach is needed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You must get that data and check whether this is a GeoJSON or TopoJSON.
And based on that you should pass the map feature.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@shivamSspirit
Copy link
Author

shivamSspirit commented Nov 29, 2021

refactor all changes, review and task for next round

@shivamSspirit
Copy link
Author

Review this

@srijitcoder
Copy link
Contributor

Screenshot 2021-12-22 at 1 17 36 PM

The UI looks little confusing and not aligned

@srijitcoder
Copy link
Contributor

image

You need to clip the shape to raster not make a layer out of it

@shivamSspirit
Copy link
Author

ok but ui on my side is correct

@shivamSspirit
Copy link
Author

Raster Playground - A color playground for raster maps  - Google Chrome 22-12-2021 13_28_26

@shivamSspirit
Copy link
Author

today I am working on the second task of clip instead of layer

@shivamSspirit
Copy link
Author

image

You need to clip the shape to raster not make a layer out of it

if you are adding the file through URL then clipping works but when you upload a file from local when added new layer on it
so you want to that add clip layer instead of vector layer when we upload file... right

@shivamSspirit
Copy link
Author

https://gifted-elion-321a04.netlify.app

review for changes
and thankyou

@shivamSspirit
Copy link
Author

review for changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants