Added search bar fixing #16 #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains changes to have search bar. I have used
ol-geocoderfor the same.While working on this feature I found that there's a issue with
ol-geocodermixed content issue(since netlify by default servers all website on https and ol-geocoder makes an api call over http) I have raised an issue for the same over here:Dominique92/ol-geocoder#231
Hence the Netlify link below won't function as intendant. I am attaching an working screen grab below:
Screen.Recording.2021-01-14.at.3.48.25.PM.mp4
Current api key for mapquest has netlify callback url set to it. if you want to test this locally please use following api key
ZKKu4cdpzmAnRNWhECIKQPdjAh55RkOZIssue: #16
Netlify Link