Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/region specific kms #22

Merged
merged 4 commits into from
Dec 4, 2017
Merged

Feature/region specific kms #22

merged 4 commits into from
Dec 4, 2017

Conversation

jyoung-asymmetrik
Copy link
Contributor

No description provided.

andrewmarcus
andrewmarcus reviewed Dec 1, 2017
View reviewed changes
Copy link
Member

@andrewmarcus andrewmarcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the purpose of doing this? I'm concerned that you may be trying to work around a problem that already has a different solution.

@jyoung-asymmetrik jyoung-asymmetrik merged commit 7a1df59 into master Dec 4, 2017
@jyoung-asymmetrik jyoung-asymmetrik deleted the feature/region-specific-kms branch December 4, 2017 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewmarcus andrewmarcus andrewmarcus left review comments

@Robert-W Robert-W Robert-W approved these changes

Assignees

@Robert-W Robert-W

@andrewmarcus andrewmarcus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jyoung-asymmetrik @Robert-W @andrewmarcus