Add check for when image build option repo is null, drop image resolves #9
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sieabah
commented
Jun 30, 2017
| @@ -88,6 +88,12 @@ function buildImages(registry) { | |||
| return function(buildOptions) { | |||
| logger.info('Building Docker Images'); | |||
| logger.info('Will build the following images:'); | |||
|
|
|||
| for(let name in buildOptions.images) | |||
There was a problem hiding this comment.
_.filter or any type of filter destroys object keys, why I ended up using for..in
There was a problem hiding this comment.
_.pickBy is the equivalent of filter for objects. https://lodash.com/docs/4.17.4#pickBy
|
Resolves #9 |
|
Looks good to me |
Robert-W
approved these changes
Jun 30, 2017
|
@andrewmarcus With how _.merge is run through it doesn't look like null falls through in the end. DockerBuildContext is always set and another parameter. I didn't want to rewrite the whole flow of building the options |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.