Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump up R version requirement #51

Closed
khufkens opened this issue Jan 2, 2020 · 6 comments
Closed

Bump up R version requirement #51

khufkens opened this issue Jan 2, 2020 · 6 comments

Comments

@khufkens
Copy link
Member

khufkens commented Jan 2, 2020

Increase the mandatory R version requirement to 3.6?

In general I've run into many troubles, either personally or when giving workshops when people run outdated R installs. Pushing for a 3.6 requirement might trap some issues which are not necessarily package related (not in 3.6 anyway).

https://github.com/khufkens/ecmwfr/blob/7ed5c96d969bf5b733671be8313350d03aa54de4/DESCRIPTION#L31

and potentially related to this: #49 (comment)

Thoughts @eliocamp ?

@eliocamp
Copy link
Collaborator

eliocamp commented Jan 2, 2020

I don't know. I wouldn't want to increase the requirements unless we are using some functionality that is not available in previous versions and hard to backport. I am not aware of any used in this package.

I use R 3.6 in all of my machines and in the last workshop I gave I used RStudio Cloud, which I think also has the most up-to-date version of R. So I don't have much experience working with old versions. What has been your experience? Does ecmwfr fail often with R < 3.6?

@khufkens
Copy link
Member Author

khufkens commented Jan 3, 2020

You are probably right, problem is that I don't test anymore on 3.4. I used to have at least one system running on 3.4 but I've upgraded all of them to >3.4. Otherwise the issue with wf_request() would have been caught earlier. I'll include a new line in the travis file.

@khufkens
Copy link
Member Author

khufkens commented Jan 3, 2020

Fixed with Travis CI integration.

Screenshot from 2020-01-03 10-45-24

@khufkens khufkens closed this as completed Jan 3, 2020
@eliocamp
Copy link
Collaborator

eliocamp commented Jan 3, 2020

For what is worth,we might get away with a lower version if we wanted to.

image

https://ateucher.shinyapps.io/check_r_versions_of_package_dependencies/

Is 3.3.0 available to test in Travis?

@eliocamp
Copy link
Collaborator

eliocamp commented Jan 3, 2020

Now I'm looking at the issue backwards and trying to figure out if it's possible to bump down the R version required. 🤣

Looking at the dependencies, why is {stars} suggested? I don't see any stars:: or library(stars) anywhere in the code. Is it a vestigial dependency?

@khufkens
Copy link
Member Author

khufkens commented Jan 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants