Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wf_requests_batch() accepts requests that overwrite each other #100

Closed
eliocamp opened this issue Aug 31, 2022 · 3 comments · Fixed by #102
Closed

wf_requests_batch() accepts requests that overwrite each other #100

eliocamp opened this issue Aug 31, 2022 · 3 comments · Fixed by #102

Comments

@eliocamp
Copy link
Collaborator

A friend of mine (definitely not me 🤣 ) sent a bunch of requests but forgot to change the filename in the target slot, so wf_requests_batch() downloaded every request in the same filename, which was a total waste of everyone's time.

Should the function check for this issue and error out early? My gut tells me it should, since I don't see any situation in which the user would want wf_requests_batch() to overwrite requests.

@khufkens
Copy link
Member

khufkens commented Sep 1, 2022

Yep, probably best to do some checks. Grab all filenames and if (any(duplicated(filenames))) {} should do the trick.

eliocamp added a commit that referenced this issue Sep 1, 2022
@eliocamp
Copy link
Collaborator Author

eliocamp commented Sep 1, 2022

There.

I've just noticed that this is issue 100! 🎉

@khufkens
Copy link
Member

khufkens commented Sep 2, 2022

Wonderful, will push this to CRAN next week or so. Stuff is piled high and deep for the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants