Skip to content
This repository has been archived by the owner on Dec 1, 2021. It is now read-only.

update pytest version to 5.2.0 #487

Merged
merged 1 commit into from
Oct 3, 2019
Merged

update pytest version to 5.2.0 #487

merged 1 commit into from
Oct 3, 2019

Conversation

tkng
Copy link
Contributor

@tkng tkng commented Oct 2, 2019

Motivation and Context

Recently, our automated tests are failed with an error message below:

TypeError: attrib() got an unexpected keyword argument 'convert'

@hadusam tought me that the version incompatibility between attrs and pytest causes this problem.

There're two solutions we can choose, 1st solution is downgrading of attrs, 2nd solution is upgrading pytest. I chose later.

see also: pytest-dev/pytest#3280

Description

just updated pytest version

How has this been tested?

unit test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature / Optimization (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@blueoil-butler blueoil-butler bot added the CI: auto-run Run CI automatically label Oct 2, 2019
@hadusam hadusam added CI: test-blueoil Run blueoil test once CI: test-lmnet Run lmnet test once labels Oct 3, 2019
@blueoil-butler blueoil-butler bot removed CI: test-blueoil Run blueoil test once CI: test-lmnet Run lmnet test once labels Oct 3, 2019
@tkng tkng mentioned this pull request Oct 3, 2019
5 tasks
@hadusam hadusam self-requested a review October 3, 2019 00:57
Copy link
Contributor

@hadusam hadusam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for early fixing!
LGTM 👍

@tkng tkng merged commit 37053c3 into blue-oil:master Oct 3, 2019
@iizukak iizukak added this to the v0.12.0 milestone Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI: auto-run Run CI automatically
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants