Skip to content

Commit

Permalink
Merge pull request #288 from blockfrost/chore/refactor-promises
Browse files Browse the repository at this point in the history 
chore: remove unnecessary promise wrap
  • Loading branch information
@vladimirvolek
vladimirvolek committed Dec 20, 2023
2 parents 9012838 + ae2911c commit c2d4220
Show file tree
Hide file tree
Showing 19 changed files with 913 additions and 1,137 deletions.
256 changes: 119 additions & 137 deletions src/endpoints/api/accounts/index.ts
View file
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,14 @@ export async function accounts(
this: BlockFrostAPI,
stakeAddress: string,
): Promise<components['schemas']['account_content']> {
return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_content']>(
try {
const res = await this.instance<components['schemas']['account_content']>(
`accounts/${stakeAddress}`,
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
);
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand All @@ -43,22 +42,20 @@ export async function accountsRewards(
): Promise<components['schemas']['account_reward_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_reward_content']>(
`accounts/${stakeAddress}/rewards`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_reward_content']
>(`accounts/${stakeAddress}/rewards`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -99,22 +96,20 @@ export async function accountsHistory(
): Promise<components['schemas']['account_history_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_history_content']>(
`accounts/${stakeAddress}/history`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_history_content']
>(`accounts/${stakeAddress}/history`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -155,22 +150,20 @@ export async function accountsWithdrawals(
): Promise<components['schemas']['account_withdrawal_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_withdrawal_content']>(
`accounts/${stakeAddress}/withdrawals`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_withdrawal_content']
>(`accounts/${stakeAddress}/withdrawals`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -211,22 +204,20 @@ export async function accountsMirs(
): Promise<components['schemas']['account_mir_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_mir_content']>(
`accounts/${stakeAddress}/mirs`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_mir_content']
>(`accounts/${stakeAddress}/mirs`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -267,22 +258,20 @@ export async function accountsDelegations(
): Promise<components['schemas']['account_delegation_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_delegation_content']>(
`accounts/${stakeAddress}/delegations`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_delegation_content']
>(`accounts/${stakeAddress}/delegations`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -323,22 +312,20 @@ export async function accountsRegistrations(
): Promise<components['schemas']['account_registration_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_registration_content']>(
`accounts/${stakeAddress}/registrations`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_registration_content']
>(`accounts/${stakeAddress}/registrations`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -382,22 +369,20 @@ export async function accountsAddresses(
): Promise<components['schemas']['account_addresses_content']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_addresses_content']>(
`accounts/${stakeAddress}/addresses`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_addresses_content']
>(`accounts/${stakeAddress}/addresses`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -441,22 +426,20 @@ export async function accountsAddressesAssets(
): Promise<components['schemas']['account_addresses_assets']> {
const paginationOptions = getPaginationOptions(pagination);

return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_addresses_assets']>(
`accounts/${stakeAddress}/addresses/assets`,
{
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
try {
const res = await this.instance<
components['schemas']['account_addresses_assets']
>(`accounts/${stakeAddress}/addresses/assets`, {
searchParams: {
page: paginationOptions.page,
count: paginationOptions.count,
order: paginationOptions.order,
},
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
});
return res.body;
} catch (error) {
throw handleError(error);
}
}

/**
Expand Down Expand Up @@ -493,13 +476,12 @@ export async function accountsAddressesTotal(
this: BlockFrostAPI,
stakeAddress: string,
): Promise<components['schemas']['account_addresses_total']> {
return new Promise((resolve, reject) => {
this.instance<components['schemas']['account_addresses_total']>(
`accounts/${stakeAddress}/addresses/total`,
)
.then(resp => {
resolve(resp.body);
})
.catch(err => reject(handleError(err)));
});
try {
const res = await this.instance<
components['schemas']['account_addresses_total']
>(`accounts/${stakeAddress}/addresses/total`);
return res.body;
} catch (error) {
throw handleError(error);
}
}
Loading

0 comments on commit c2d4220

Please sign in to comment.