Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Username is case-sensitive #7

Closed
Nightcaat opened this issue Jun 28, 2018 · 5 comments
Closed

Username is case-sensitive #7

Nightcaat opened this issue Jun 28, 2018 · 5 comments
Assignees
@y21
Labels
backend Relates to the backend bug Something isn't working good first issue Good for newcomers
Projects
Backend

Comments

@Nightcaat
Copy link
Contributor

I can't log in as "nightcat" and I assume that someone would be able to register as "nightcat" so please fix that!
@Nightcaat Nightcaat added bug Something isn't working backend Relates to the backend labels Jun 28, 2018
@Nightcaat Nightcaat added this to To do in Backend Jun 28, 2018
@y21
Copy link
Contributor

y21 commented Jun 28, 2018

You can't login? What error does it give to you?

@Nightcaat
Copy link
Contributor Author

It just says "Incorrect username or password."

@y21
Copy link
Contributor

y21 commented Jun 28, 2018

Oh, I totally got it wrong. I know what you mean. Good idea!

@y21 y21 added good first issue Good for newcomers meta: request labels Jun 28, 2018
y21 added a commit that referenced this issue Oct 25, 2018
@y21
Case insensitive username checking (#7)
daa0ec3
@y21
Copy link
Contributor

y21 commented Oct 25, 2018

Fixed in daa0ec3; it now checks if the username already exists, no matter if the original name has different capitalization.
In other words: nobody will be able to register as nightcat or NIGhtCaT.

@y21 y21 closed this as completed Oct 25, 2018
@Nightcaat Nightcaat moved this from To do to Done in Backend Oct 25, 2018
@Nightcaat
Copy link
Contributor Author

Registration works as intended, but I can still only log in as Nightcat.

@Nightcaat Nightcaat reopened this Nov 18, 2019
@Nightcaat Nightcaat moved this from Done to In progress in Backend Nov 18, 2019
@y21 y21 closed this as completed in 2317d54 Nov 19, 2019
@y21 y21 moved this from In progress to Done in Backend Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@y21 y21

Labels
backend Relates to the backend bug Something isn't working good first issue Good for newcomers
Projects
Backend
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Nightcaat @y21