Use zoom space id in Onvif RelativeMove setup #9859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
blakeblackshear
approved these changes
Feb 16, 2024
hawkeye217
added a commit
that referenced
this pull request
Feb 24, 2024
* use zoom space id in onvif relativemove setup * better handle cases when zooming is disabled
NickM-27
added a commit
that referenced
this pull request
Feb 24, 2024
* Use zoom space id in Onvif RelativeMove setup (#9859) * use zoom space id in onvif relativemove setup * better handle cases when zooming is disabled * Fix birdseye camera comparison (#9887) * Format (#9889) * use first onvif profile with ptz config * Use zoom space id in Onvif RelativeMove setup (#9859) * use zoom space id in onvif relativemove setup * better handle cases when zooming is disabled * use first onvif profile with ptz config --------- Co-authored-by: Nicolas Mowen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a small bug (found in #9855) that may prevent some users from using autotracking when their camera actually supports it. Regardless of the autotracking zooming mode set (absolute or relative), a relative zoom onvif space is required to be set in the RelativeMove request.