Performance increase with lots of recordings #8525
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
| @@ -1584,20 +1584,10 @@ def recordings_summary(camera_name): | |||
| ) | |||
| .where(Recordings.camera == camera_name) | |||
| .group_by( | |||
| fn.strftime( | |||
There was a problem hiding this comment.
This is removing the timezone handling for recordings which is incorrect
There was a problem hiding this comment.
Why so? Grouping is done by the hour, which does not depend on timezone?
There was a problem hiding this comment.
it does depend on the timezone, the api accepts a timezone query arg which affects how hours are displayed. That timezone query arg is now just ignored in this implementation
There was a problem hiding this comment.
It isn't ignored, it is still in the select part of the query. Only grouping is now done based on the Unix epoch, the output of the query is exactly the same.
There was a problem hiding this comment.
I see what you're saying, this will still cause problems for timezones that have 30 minute and 15 minute offsets from UTC
There was a problem hiding this comment.
You could perhaps catch the case that minute_modifier is not 0 and use the current grouping in that case or if it is 0 use your new grouping
| @@ -0,0 +1,44 @@ | |||
| """Peewee migrations -- 011_update_indexes.py. | |||
There was a problem hiding this comment.
Title should be updated here
There was a problem hiding this comment.
Copy paste error. Will change it.
| @@ -1584,20 +1584,10 @@ def recordings_summary(camera_name): | |||
| ) | |||
| .where(Recordings.camera == camera_name) | |||
| .group_by( | |||
| fn.strftime( | |||
There was a problem hiding this comment.
You could perhaps catch the case that minute_modifier is not 0 and use the current grouping in that case or if it is 0 use your new grouping
|
I think it would be interesting to know data points for the improvements you are seeing, for me looks like about 100ms average on the recordings page before
after
|
The difference on my side was even bigger. All depends on the number of recordings of course. Visiting the storage page on the frontend is also a lot quicker, refreshes are nearly instant at my side. |
I noticed long query times on my database with lots of recordings, therefore I changed some code and databases indices. I see a serious performance increase on all queries running on the recordings table.