Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write recording segments to cache with timezone info #8468

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Write recording segments to cache with timezone info #8468

merged 3 commits into from
Nov 5, 2023

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Nov 5, 2023

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 5, 2023 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit d3044c5
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/654796c10e3ab10008c7e4c4

@NickM-27 NickM-27 changed the title Write recording segments to cache with timezone info Use ctime from cached recording segments instead of timezone naive file names Nov 5, 2023
@NickM-27 NickM-27 marked this pull request as draft November 5, 2023 12:20
@NickM-27 NickM-27 marked this pull request as ready for review November 5, 2023 12:22
@NickM-27 NickM-27 marked this pull request as draft November 5, 2023 12:30
@NickM-27 NickM-27 changed the title Use ctime from cached recording segments instead of timezone naive file names Write recording segments to cache with timezone info Nov 5, 2023
@NickM-27 NickM-27 marked this pull request as ready for review November 5, 2023 13:26
@blakeblackshear blakeblackshear merged commit 89dd114 into dev Nov 5, 2023
10 checks passed
@blakeblackshear blakeblackshear deleted the record-cache-tz branch November 5, 2023 20:30
@xconverge
Copy link
Contributor

@NickM-27 I can open an issue if you want but figured I would just put it here so you can see this:

2023-11-06 09:18:33.981584492  [2023-11-06 09:18:33] frigate.record.maintainer      ERROR   : Error occurred when attempting to maintain recording cache
2023-11-06 09:18:33.981676903  [2023-11-06 09:18:33] frigate.record.maintainer      ERROR   : can't compare offset-naive and offset-aware datetimes
2023-11-06 09:18:38.908842051  [2023-11-06 09:18:38] frigate.record.maintainer      ERROR   : Error occurred when attempting to maintain recording cache
2023-11-06 09:18:38.908922492  [2023-11-06 09:18:38] frigate.record.maintainer      ERROR   : can't compare offset-naive and offset-aware datetimes
2023-11-06 09:18:43.905393639  [2023-11-06 09:18:43] frigate.record.maintainer      WARNING : Unable to keep up with recording segments in cache for floodlight. Keeping the 5 most recent segments out of 6 and discarding the rest...
2023-11-06 09:18:43.905830867  [2023-11-06 09:18:43] frigate.record.maintainer      WARNING : Unable to keep up with recording segments in cache for front. Keeping the 5 most recent segments out of 6 and discarding the rest...
2023-11-06 09:18:43.992017515  [2023-11-06 09:18:43] frigate.record.maintainer      ERROR   : Error occurred when attempting to maintain recording cache
2023-11-06 09:18:43.992090973  [2023-11-06 09:18:43] frigate.record.maintainer      ERROR   : can't compare offset-naive and offset-aware datetimes
2023-11-06 09:18:48.905612625  [2023-11-06 09:18:48] frigate.record.maintainer      ERROR   : Error occurred when attempting to maintain recording cache
2023-11-06 09:18:48.905699342  [2023-11-06 09:18:48] frigate.record.maintainer      ERROR   : can't compare offset-naive and offset-aware datetimes
2023-11-06 09:18:53.898995585  [2023-11-06 09:18:53] frigate.record.maintainer      WARNING : Unable to keep up with recording segments in cache for floodlight. Keeping the 5 most recent segments out of 6 and discarding the rest...
2023-11-06 09:18:53.899093525  [2023-11-06 09:18:53] frigate.record.maintainer      WARNING : Unable to keep up with recording segments in cache for front. Keeping the 5 most recent segments out of 6 and discarding the rest...
2023-11-06 09:18:53.978903923  [2023-11-06 09:18:53] frigate.record.maintainer      ERROR   : Error occurred when attempting to maintain recording cache
2023-11-06 09:18:53.978971721  [2023-11-06 09:18:53] frigate.record.maintainer      ERROR   : can't compare offset-naive and offset-aware datetimes

I assume this is related to this PR, anything I need to clear or restart?

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented Nov 6, 2023

Thanks, I see the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakeblackshear blakeblackshear blakeblackshear approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickM-27 @xconverge @blakeblackshear