Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show event duration in landscape mode #8301

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Show event duration in landscape mode #8301

merged 2 commits into from
Oct 26, 2023

Conversation

tpjanssen
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Oct 24, 2023 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 3edbcc8
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6537de87a99d54000888544f

@NickM-27
Copy link
Sponsor Collaborator

I don't think this is the right approach. You could have a vertical monitor that is plenty wide enough to show the duration.

@tpjanssen
Copy link
Contributor Author

Changed from landscape to sm. Did multiple tests (devices and resolutions) in Chrome's developer tools, all work as intended. Old behaviour was not working as expected with a vertical monitor, as @NickM-27 correctly stated.

@blakeblackshear blakeblackshear merged commit 859ab0e into blakeblackshear:dev Oct 26, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tpjanssen @NickM-27 @blakeblackshear