Fix bug forcing rtsp for audio detection ffmpeg process #8156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
NickM-27
force-pushed
the
audio-input-args
branch
from
7f7f72d
to
5d44318
Compare
NickM-27
force-pushed
the
audio-input-args
branch
from
5d44318
to
6ad81b9
Compare
blakeblackshear
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug forcing rtsp input args in the audio process, this is wrong and the configured ffmpeg input args should work same as for detect and record processes
the args must be joined as a list to the user agent is not split on the space. this remains consistent with how ffmpeg commands are used elsewhere in the codebase