Refresh page when websocket is closed but user has interacted with page #8155
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
| // if ws is closed but user has interacted with page | ||
| // refresh to ensure state is up to date | ||
| if (ws.readyState == WebSocket.CLOSED) { | ||
| location.reload(); |
There was a problem hiding this comment.
Is there not a way to try reconnecting the websocket without a refresh?
There was a problem hiding this comment.
I couldn't figure out how to do that because ws object does not have that function directly and the send function doesn't have access to the fields necessary to rebuild the ws object.
I believe refreshing may provide some utility in the case that frigate has stopped but the user tries to interact with the webUI.
That being said, I believe @hawkeye217 may have a better way to fix this
There was a problem hiding this comment.
I've used react-use-websocket before, it's pretty simple and robust. But I'm not sure it has preact compatibility (we're running 17.1.2 and the latest version needs react >= 18) so unless we want to go down the react-compat route, my fix may not be as straightforward as I would have hoped. I'll try an older version and see what happens.
|
will be replaced by separate PR |
fixes #5000