use constants instead of hard-coded values in audio-maintainer and http-external-event-handler #7586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
…ts and enums respectively
skrashevich
force-pushed
the
230827-codeqa-audio-events-constants
branch
from
4ddab82
to
7b40390
Compare
NickM-27
requested changes
Aug 27, 2023
| @@ -199,7 +199,7 @@ def detect_audio(self, audio) -> None: | |||
| continue | |||
|
|
|||
| if score > dict((self.config.audio.filters or {}).get(label, {})).get( | |||
| "threshold", 0.8 | |||
| "threshold", AUDIO_MIN_CONFIDENCE | |||
There was a problem hiding this comment.
This is incorrect, 0.8 is the default min confidence for a filter, not 0.5 which is the min confidence for any audio detection
There was a problem hiding this comment.
class AudioFilterConfig(FrigateBaseModel):
threshold: float = Field(
default=0.8,
ge=AUDIO_MIN_CONFIDENCE,
lt=1.0,
title="Minimum detection confidence threshold for audio to be counted.",
)
0.5<0.8
There was a problem hiding this comment.
0.5<0.8
Yes exactly, which is why this is incorrect. Not only does it not match the docs / default config, it is being more permissive than the default that has been set.
There was a problem hiding this comment.
hm. I'll re-check this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.