Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Show label & sub labels values next to the score #7121

Merged

Conversation

skrashevich
Copy link
Contributor

frigate-labels-switch

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit d0cef6a
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/64ad434dc2fa080008b77bcd

…lude the event label and sub-label percentage
@blakeblackshear
Copy link
Owner

I don't see a reason for this.

@skrashevich
Copy link
Contributor Author

skrashevich commented Jul 11, 2023

If sub-label exists, string "Label: 94%, SubLabel: 98%" is really non-intuitive: needs to remember, what is a label and what is sub-label...
image
IMHO, it's not user-friendly

@blakeblackshear
Copy link
Owner

Users already need to know what a sublabel is to use the dropdown filters above.

If we think it would be more intuitive to show the label and sublabel values instead, then let's just do that. There is no reason to have it be switchable.

@skrashevich
Copy link
Contributor Author

If we think it would be more intuitive to show the label and sublabel values instead, then let's just do that. There is no reason to have it be switchable.

done :)

@NickM-27 NickM-27 changed the title WebUI: switch labels display mode by click on Events page WebUI: Show label & sub labels values next to the score Jul 11, 2023
@blakeblackshear blakeblackshear merged commit 6d34f22 into blakeblackshear:dev Jul 14, 2023
11 checks passed
@skrashevich skrashevich deleted the 230711-webui-labels-switch branch August 24, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants