-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Community Supported Boards Framework #7114
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
7b2cec1
to
7409404
Compare
Maybe it makes sense if the base branch is running on a platform for which there is a Community build - show a notification in the webUI about it? |
I think it would be difficult to know for sure what the current platform is given that frigate runs in docker. |
|
I see, could make sense although frigate doesn't really have a notifications system right now. Either way, that is outside the scope of this PR 👍 |
Is the intent to just have "local" targets for community-supported builds, or can there be tagged, cross-compileable make targets too? |
I just forgot to add that to the Makefile 👍 |
7d8c5c2
to
f9a06f3
Compare
I'd like to propose making the makefile a bit more dynamic with community builds. I think we should move the rpi targets to their own file inside the BOARDS += rpi
local-rpi: version local
docker buildx build --tag frigate:latest-rpi --build-arg BASE_IMAGE=frigate:latest --load --file docker/build/rpi/Dockerfile .
build-rpi: arm64
docker buildx build --platform linux/arm64 --build-arg BASE_IMAGE=$(IMAGE_REPO):${VERSION}-$(COMMIT_HASH) --tag $(IMAGE_REPO):${VERSION}-$(COMMIT_HASH)-rpi --file docker/build/rpi/Dockerfile .
push-rpi: build-rpi
docker buildx build --push --platform linux/arm64 --build-arg BASE_IMAGE=$(IMAGE_REPO):${VERSION}-$(COMMIT_HASH) --tag $(IMAGE_REPO):${GITHUB_REF_NAME}-$(COMMIT_HASH)-rpi --file docker/build/rpi/Dockerfile . If these sub makefiles use the same pattern of make targets (i.e. build-{board-name} and push-{board-name}), we can include them in the top-level makefile like so: BOARDS= #Initialized empty
include docker/build/*/*.mk
build-boards: $(BOARDS:%=build-%)
push-boards: $(BOARDS:%=push-%) It is also possible to build any of the board-specific targets directly, such as doing |
5356e8b
to
a00cf08
Compare
Consider moving |
eff7440
to
410c1d3
Compare
Consider moving |
5b8119e
to
a263489
Compare
Approved - I was able to rebase the Jetson changes elegantly on top of this. |
6ed64c7
to
6c2e60d
Compare
No description provided.