Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio events #6848

Merged
merged 51 commits into from
Jul 1, 2023
Merged

Audio events #6848

merged 51 commits into from
Jul 1, 2023

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented Jun 19, 2023

The initial implementation of the audio events feature is going to be minimal. The audio model runs well on CPU so that will be the only option.

To-Do:

  • Cleanup labelmap
  • Add ability to enable / disable audio events via MQTT
  • Optimize stop event logic

@netlify
Copy link

netlify bot commented Jun 19, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit d8af7fb
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/64a02583cf582000095c4258
😎 Deploy Preview https://deploy-preview-6848--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@NickM-27 NickM-27 marked this pull request as draft June 19, 2023 14:07
@blakeblackshear
Copy link
Owner

This looks good. We just need the docs updated.

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented Jul 1, 2023

This looks good. We just need the docs updated.

Let me know what you think, I figured it didn't make sense to put the object detector and audio detector docs in the same docs page because it could get confusing

@blakeblackshear blakeblackshear merged commit c3b313a into dev Jul 1, 2023
11 checks passed
@blakeblackshear blakeblackshear deleted the audio-events branch July 1, 2023 13:20
@RobinBeismann
Copy link

Hey @NickM-27,

thanks for this feature! Any idea when it is going to make it into the stable branch?

@Dodoooh
Copy link

Dodoooh commented Nov 8, 2023

i'm also looking forward to this, is there any news?

@niemyjski
Copy link

Any reason why there are so many duplicate event names in the list? https://github.com/blakeblackshear/frigate/blob/dev/audio-labelmap.txt

@NickM-27
Copy link
Sponsor Collaborator Author

Because they were a slight variation of that same thing so the name is duplicated so they are called the same thing.

Makes it easier for users so you don't need kid_yell, adult_yell, etc

@niemyjski
Copy link

Look at the list, the first 4 items are the same value

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented Jan 31, 2024

yes, and that is on purpose as I just explained. If you look at the original list they are not the same, they have been made the same to make the audio events more user friendly and simpler to setup

@niemyjski
Copy link

That's really confusing to end users, especially when it's linked to from the docs.

@NickM-27
Copy link
Sponsor Collaborator Author

it's the same thing as why car is listed twice for the object list https://docs.frigate.video/configuration/objects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants