Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to enable / disable stats that require external processes #6615

Merged
merged 9 commits into from
Jun 11, 2023

Conversation

NickM-27
Copy link
Sponsor Collaborator

Closes #6613

@NickM-27 NickM-27 changed the title Nethog option Option to disable network bandwidth stats May 25, 2023
@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for frigate-docs ready!

Name Link
🔨 Latest commit c845a46
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6485c4ee696f6b0008e3e495
😎 Deploy Preview https://deploy-preview-6615--frigate-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@NickM-27 NickM-27 changed the title Option to disable network bandwidth stats Option to enable / disable network bandwidth stats May 25, 2023
@skrashevich
Copy link
Contributor

it's overkill for resolve #6613 :)

@NickM-27
Copy link
Sponsor Collaborator Author

Maybe, but I agree that many users (like myself) won't have use for these and there's no sense taking up extra time for stats which aren't needed, especially as more and more types of stats are added.

@blakeblackshear
Copy link
Owner

Perhaps we should expand this scope to allow disabling all stats that require spawning external processes. The system page used to be very fast. For example, gpu usage never really changes once things are up and running.

@skrashevich
Copy link
Contributor

Absolutely agree. I was precisely endeavoring to minimize the invocation of external processes during the statistics calculations (#6298, #6344, #6359).

@NickM-27 NickM-27 changed the title Option to enable / disable network bandwidth stats Option to enable / disable stats that require external processes Jun 6, 2023
docs/docs/configuration/index.md Outdated Show resolved Hide resolved
docs/docs/configuration/index.md Outdated Show resolved Hide resolved
@blakeblackshear blakeblackshear merged commit 3256984 into dev Jun 11, 2023
10 checks passed
@blakeblackshear blakeblackshear deleted the nethog-option branch June 11, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Support]: nethogs CPU usage
3 participants