feat(nginx): enable gzip compression and cache control for static files #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| location ~* \.(?:js|css|svg|ico|png)$ { | ||
| access_log off; | ||
| expires 1y; | ||
| add_header Cache-Control "public"; |
There was a problem hiding this comment.
Should we set a corresponding Cache-Control header for the api and html endpoints to ensure they don't get cached?
There was a problem hiding this comment.
Makes sense to me. Updated the /api and default for web.
★ curl -I http:https://localhost:5000/api/events
HTTP/1.1 200 OK
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 29 Jan 2021 17:43:37 GMT
Content-Type: application/json
Content-Length: 1188808
Connection: keep-alive
Vary: Accept-Encoding
Access-Control-Allow-Origin: *
Cache-Control: no-store
★ curl -I http:https://localhost:5000/
HTTP/1.1 200 OK
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 29 Jan 2021 17:43:46 GMT
Content-Type: text/html
Connection: keep-alive
Vary: Accept-Encoding
Cache-Control: no-cache
★ curl -I http:https://localhost:5000/favicon.ico
HTTP/1.1 200 OK
Server: nginx/1.18.0 (Ubuntu)
Date: Fri, 29 Jan 2021 17:43:52 GMT
Content-Type: image/x-icon
Content-Length: 15086
Last-Modified: Fri, 29 Jan 2021 16:20:14 GMT
Connection: keep-alive
ETag: "601435be-3aee"
Expires: Sat, 29 Jan 2022 17:43:52 GMT
Cache-Control: max-age=31536000
Cache-Control: public
Accept-Ranges: bytes
There was a problem hiding this comment.
Looking again, I'd like to make sure JSON api responses get gzipped correctly. Going to update again…
There was a problem hiding this comment.
Alright, that's better. Required the gzip_proxied line.
paularmstrong
force-pushed
the
nginx_gzip_cache
branch
from
4276e2a
to
ab7d59d
Compare
paularmstrong
force-pushed
the
nginx_gzip_cache
branch
from
ab7d59d
to
38511fe
Compare
blakeblackshear
approved these changes
Jan 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before (without images, transfer size = 116kB)
After (without images, transfer size = 52kB)
Closes #653