Record annotation offset #6288
Merged
Record annotation offset #6288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs canceled.
|
|
We could also consider baking this offset into the start/end times in the recording database entries instead. That would also fix other related inconsistencies. |
The thing is, when I check my recordings they are (from what I can see) exactly in line with what they're saved as. So if it's going to be changing permanently how values are stored, I think it might make more sense to offset the frame times that are stored? |
|
Yea. This may be a better solution to start with. We can at least evaluate how consistent it is with this. |
NickM-27
force-pushed
the
record-annotation-offset
branch
from
02d3f5c
to
d5b12b1
Compare
blakeblackshear
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.