Adding PERFMON capability to docs #5801
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
NickM-27
requested changes
Mar 21, 2023
There was a problem hiding this comment.
I don't think this should be recommended by default in the docker config installation docs as it will cause confusion. I tried it on Unraid which runs linux kernel 6.1.20 and it failed due to unknown capability. Also, nvidia-smi and radeontop don't require this capability.
I would suggest adding a section to the Hardware Acceleration docs for GPU stats and mention this there
There was a problem hiding this comment.
Ah, that's a Docker thing it seems...
Might want to park this until Docker fixes it.
There was a problem hiding this comment.
ah yes, makes sense then 👍
|
Closing this until docker/cli#3960 is completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #5795 for details.
Tools like
intel_gpu_topneedCAP_PERFMONwhich needs to be added when running containers in non-privileged mode (which is best practice).Adding that capability requires Kernel >= 5.8.