-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate default database path from /media/frigate
to /config
#5219
Migrate default database path from /media/frigate
to /config
#5219
Conversation
✅ Deploy Preview for frigate-docs canceled.
|
@NickM-27 this is working for me. Feel free to take an early look on it, if you want. |
You'll probably also want to update the config to point to the new location by default |
lol that's the most important part. Thank you. |
Wouldn't /config/db make more sense (as the db is made up of several files)? Not sure if this would impact the docker mappings or not.. Some might want the ability to separate the config file and where the DB is stored if they have particularly huge setups or for backup reasons. |
This is already possible with frigate. This PR simply changes the default location. |
can we get this rebased? I am ready to merge this. |
Sure, I'll work on it. |
/media/frigate
to /config
@blakeblackshear done. |
Just to remind, we should remove the following line for the add-on by the time we release the next beta: |
what's the reasoning for that? |
Actually it's not mandatory, it's just superfluous to have it set. |
I don't think that is correct. The file in addon is supposed to be called frigate.yml but by default frigate always looks for config.yml. The only way the addon knows to look for frigate.yml is because of this variable |
Oh, that's right. Never mind, my bad! |
this isn't working for me, it is exiting saying that the config file can not be found, but it is located at |
I think the substitution was mixed up, will put up a PR to fix |
/data
by default? #4856