Docs: Fix link to contributing docs, clarify go2rtc config #5076
Conversation
Docs: Make go2rtc docs a little more clear
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -21,7 +21,14 @@ webRTC works by creating a websocket connection on extra ports. One of the follo | |||
| * Frigate is run with `network_mode: host` to support automatic UDP port pass through locally and remotely. See https://github.com/AlexxIT/go2rtc#module-webrtc for more details | |||
| * Frigate is run with `network_mode: bridge` and has: | |||
| * Router setup to forward port `8555` to port `8555` on the Frigate device. | |||
| * For local webRTC, you will need to create your own go2rtc config: | |||
| * Added port to your docker ports list, for example: | |||
There was a problem hiding this comment.
I think we need to elaborate on this a bit more. Explain that docker users need to map the ports and on the addon side these ports are disabled by default and need to be enabled in the addon config.
There was a problem hiding this comment.
actually I think we are going to pass 8555 by default since it is not exposing data when not being used
|
|
||
| ```yaml | ||
| volumes: | ||
| - /path/to/your/go2rtc.yaml:/config/frigate-go2rtc.yaml:ro | ||
| ``` | ||
|
|
||
| See https://github.com/AlexxIT/go2rtc#module-webrtc for more details on configuring go2rtc. |
There was a problem hiding this comment.
If this is just for configuring go2rtc then we should link to the repo generally and not the webrtc section
| ```yaml | ||
| ports: | ||
| - "5000:5000" # Frigate Web UI | ||
| - "8555:8555" # go2rtc |
There was a problem hiding this comment.
This needs to be updated like the installation docs to pass both 8555 tcp and 8555 udp. Also probably needs to be formatted.
| @@ -21,7 +21,14 @@ webRTC works by creating a websocket connection on extra ports. One of the follo | |||
| * Frigate is run with `network_mode: host` to support automatic UDP port pass through locally and remotely. See https://github.com/AlexxIT/go2rtc#module-webrtc for more details | |||
| * Frigate is run with `network_mode: bridge` and has: | |||
| * Router setup to forward port `8555` to port `8555` on the Frigate device. | |||
| * For local webRTC, you will need to create your own go2rtc config: | |||
| * Added port to your docker ports list, for example: | |||
There was a problem hiding this comment.
actually I think we are going to pass 8555 by default since it is not exposing data when not being used
Docs: Fix link to contibuting docs
Docs: Make go2rtc docs a little more clear