Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement: Experimental UI #3298

Merged
merged 15 commits into from
Jul 19, 2022
Merged

improvement: Experimental UI #3298

merged 15 commits into from
Jul 19, 2022

Conversation

johnmarksilly
Copy link
Contributor

@johnmarksilly johnmarksilly commented Jun 2, 2022 •
edited
Loading

Experimental UI

Improvements

  • Modified video player to use Video.js to support browsers that can't natively stream HLS
  • Fixed glitch where the height of the container wouldn't stay the same causing it to be a pain to scrub through events.

@johnmarksilly johnmarksilly marked this pull request as ready for review June 24, 2022 14:41
@johnmarksilly
Copy link
Contributor Author

@blakeblackshear @NickM-27 Looks like something is wrong with the Python test build. One of the Docker run steps fails.

@NickM-27
Copy link
Sponsor Collaborator

@blakeblackshear @NickM-27 Looks like something is wrong with the Python test build. One of the Docker run steps fails.

Our ffmpeg version 4.3.2-1 was removed from the jellyfin repo so it's not resolving. That version also has had issues for users so we'll be switching to a new version for the next beta.

@johnmarksilly johnmarksilly mentioned this pull request Jun 24, 2022
Merged
10 tasks
@blakeblackshear
Copy link
Owner

can you rebase this?

@johnmarksilly
Copy link
Contributor Author

Rebase on to which branch/commit?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented Jun 30, 2022 •
edited
Loading

Rebase on to which branch/commit?

I think just need to rebase to latest release-0.11.0 commit so the tests pass

@johnmarksilly
Copy link
Contributor Author

@NickM-27 Good to go

@blakeblackshear blakeblackshear merged commit 6f7fc20 into blakeblackshear:release-0.11.0 Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NickM-27 NickM-27 NickM-27 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnmarksilly @NickM-27 @blakeblackshear