Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEAT: Notifications In Frigate Frontend #3243

Closed
wants to merge 1 commit into from

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented May 21, 2022

Idea

Per #3185 (comment)
It is a good idea for frigate to be able to post certain notifications.

Supported Notification Types (curently)

  • recording storage < 10%
  • Frigate update is available (current stats and latest GitHub release version comparison)
  • camera_fps of cameras and if it is 0.0 assumes there is an ffmpeg error. (This may not be good logic, not 100% sure.)

If anyone has any ideas or thoughts please let me know 馃憤

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 22, 2022

Here are some screenshots showing the current UI:

Screen Shot 2022-05-22 at 10 19 38 AM

Note that the icon will only show when there ARE notifications returned by the API, otherwise it will not show at all. The yellow color (which is set to always be the color) is intended to convey that there are warnings but if this isn't a good choice then happy to change this.

@Raphael909
Copy link

This is fantastic! Wondering if such information can be sent over via MQTT. HASS can listen to this and send a apple or android notification!. Thoughts?

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 23, 2022

This is fantastic! Wondering if such information can be sent over via MQTT. HASS can listen to this and send a apple or android notification!. Thoughts?

Thanks! They're not really fired off live right, it's just a calculated list. I'm not sure when HASS would receive them unless it was just a problem sensor that always had a value that HASS fetched

@NickM-27
Copy link
Sponsor Collaborator Author

This is what the UI looks like after latest changes:

Screen Shot 2022-05-23 at 8 18 44 AM

@NickM-27 NickM-27 marked this pull request as ready for review May 23, 2022 14:22
@coldkevin
Copy link

Considering I just filled up a disk where my recordings live on my server and basically crashed it for a few hours.... id love notifications via the gui! I rarely check in on my server ( sigh.... ) but I check frigate daily for new events.

@DrSpaldo
Copy link

Good idea :)

@NickM-27
Copy link
Sponsor Collaborator Author

Here's a screenshot example for frigate update

Screen Shot 2022-05-31 at 16 02 47 PM

Currently it doesn't support clicking / url. I think the Frigate update could point to the releases page, but not sure where the other ones would link to so maybe better to leave that out for now?

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 31, 2022

I think this is ready for initial review / comments

Also to be clear, I have no preference on if it goes into 0.11 or stays until 0.12 馃憤

@DrSpaldo
Copy link

Having the update check / info is great. The link could probably be somewhat dynamic; either go to the releases page or wherever depending on what level of release you are at or stage of development Frigate is at

@NickM-27
Copy link
Sponsor Collaborator Author

NickM-27 commented May 31, 2022

Having the update check / info is great. The link could probably be somewhat dynamic; either go to the releases page or wherever depending on what level of release you are at or stage of development Frigate is at

Right, that one is easy, but the dead camera, low storage, etc. notifications have no link that would work for all install types

@DrSpaldo
Copy link

DrSpaldo commented Jun 1, 2022

Right, that one is easy, but the dead camera, low storage, etc. notifications have no link that would work for all install types

I see the dead camera notification link taking you to the debug page. It shows all the camera stats.

The low storage, there isn鈥檛 anywhere it really can take you link wise, so that would just be purely letting you know I think..

@NickM-27
Copy link
Sponsor Collaborator Author

Went ahead and added some tests for the notifications endpoint to make sure the values are what they should be. Could be expanded in another PR to test more endpoints.

@NickM-27 NickM-27 marked this pull request as draft June 28, 2022 12:34
@NickM-27 NickM-27 changed the title Ability to post notifications in frontend FEAT: Notifications In Frigate Frontend Jun 30, 2022
@NickM-27 NickM-27 added the enhancement New feature or request label Sep 23, 2022
@NickM-27 NickM-27 changed the base branch from release-0.11.0 to dev September 25, 2022 02:37
@NickM-27
Copy link
Sponsor Collaborator Author

Going to go ahead and close this, I think there will be a much better way to do this after the recent changes coming in 0.12

@NickM-27 NickM-27 closed this Nov 23, 2022
@DrSpaldo
Copy link

Going to go ahead and close this, I think there will be a much better way to do this after the recent changes coming in 0.12

Any hints on the coming changes?

@NickM-27
Copy link
Sponsor Collaborator Author

Going to go ahead and close this, I think there will be a much better way to do this after the recent changes coming in 0.12

Any hints on the coming changes?

No need for hints you can read about it here #4055

@NickM-27 NickM-27 deleted the ui-notifications branch August 13, 2023 02:09
@NickM-27 NickM-27 restored the ui-notifications branch August 13, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants