Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 16x Playback rate to VideoPlayer.jsx #3179

Merged

Conversation

carlos-sarmiento
Copy link
Contributor

Chrome supports 16x playback rate for videos. Sometimes when I'm looking for something that happened, 8x rate can be too slow. Adding the new playback rate for frigate

@netlify
Copy link

netlify bot commented May 2, 2022

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 71d9200
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/62703a2466b7510008260b69

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented May 2, 2022

Hi, thanks for the PR. New features / behavior changes should target release-0.11.0 not master

@carlos-sarmiento carlos-sarmiento changed the base branch from master to release-0.11.0 May 2, 2022 20:48
@blakeblackshear
Copy link
Owner

Seems like something videojs would handle for us. Do their docs have any recommendations?

@NickM-27
Copy link
Sponsor Collaborator

NickM-27 commented May 3, 2022

Seems like something videojs would handle for us. Do their docs have any recommendations?

Interesting, yeah that would make sense. I don't see anything in their docs: https://videojs.com/guides/options/#playbackrates

will have to see if there are any others spots in the docs with recommendations

@carlos-sarmiento
Copy link
Contributor Author

So Playback speed is not controlled by video.js but by the browser (it is actually a property of the <video /> tag). From what I could see on the documentation, they allow any arbitrary positive number for playback speed. The limiting factor seems to be the browsers which, at least on my machine, do not support anything beyond 16.

@blakeblackshear blakeblackshear merged commit 90bff60 into blakeblackshear:release-0.11.0 May 14, 2022
@carlos-sarmiento carlos-sarmiento deleted the patch-1 branch May 14, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants