Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve audio conversion tip #2140

Merged
merged 5 commits into from
Dec 29, 2021
Merged

Improve audio conversion tip #2140

merged 5 commits into from
Dec 29, 2021

Conversation

felipecrs
Copy link
Contributor

@felipecrs felipecrs commented Oct 28, 2021

I spent quite a good time to figure out that -c copy overlaps with -c:a aac.

@netlify
Copy link

netlify bot commented Oct 28, 2021

✔️ Deploy Preview for frigate-docs ready!

🔨 Explore the source changes: 26515c6

🔍 Inspect the deploy log: https://app.netlify.com/sites/frigate-docs/deploys/61cc65dbf64dad0007e7bc42

😎 Browse the preview: https://deploy-preview-2140--frigate-docs.netlify.app

@stale
Copy link

stale bot commented Nov 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 28, 2021
@felipecrs
Copy link
Contributor Author

Hey maintainers, I think this one is quite simple and would be a good addition to the docs. No?

@stale stale bot removed the stale label Nov 29, 2021
@stale
Copy link

stale bot commented Dec 29, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 29, 2021
@felipecrs
Copy link
Contributor Author

felipecrs commented Dec 29, 2021

/cc @blakeblackshear

@stale stale bot removed the stale label Dec 29, 2021
@blakeblackshear
Copy link
Owner

I haven't merged this because I would rather show a full example of the output args with audio added. This still seems just as confusing.

@felipecrs
Copy link
Contributor Author

Sure, let me see if I can enhance this.

@felipecrs
Copy link
Contributor Author

@blakeblackshear done. Please let me know if it looks better.

@blakeblackshear blakeblackshear merged commit bb68a24 into blakeblackshear:master Dec 29, 2021
@felipecrs felipecrs deleted the patch-1 branch December 29, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants