Set image height to make bandwidth usage lower #12024
Merged
+18
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
hawkeye217
approved these changes
Jun 17, 2024
rroller
reviewed
Jun 17, 2024
| useEffect(() => { | ||
| if (!config || !imgRef.current) { | ||
| return; | ||
| } | ||
|
|
||
| imgRef.current.src = `${apiHost}api/${name}/latest.jpg${ |
There was a problem hiding this comment.
I can def see a reduction of image quality on my mobile now. Looks worse. I liked the high quality previews before. Anyway we can have this as a configurable option?
There was a problem hiding this comment.
the bandwidth usage was considerable and it had the possibility of causing live to take longer to startup. It is possible adjustments will be made to the quality but I don't see this being configurable
There was a problem hiding this comment.
Thanks. The quality looks pretty bad for me and is a big downgrade. I hope that can be addressed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.