Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI tweaks #11795

Merged
merged 3 commits into from
Jun 7, 2024
Merged

UI tweaks #11795

merged 3 commits into from
Jun 7, 2024

Conversation

hawkeye217
Copy link
Collaborator

@hawkeye217 hawkeye217 commented Jun 7, 2024

  • Prevent "undefined" from being displayed in searchParams string. When searchParams is undefined, the expression with a logical && evaluates to undefined. So the string ends up being /latest.jpg?cache=1717728081280undefined. This fix corrects this bug and mimics the existing code in the ResizingCameraImage component.
  • Display a message when a selected review period has no motion data rather than a spinning activity indicator. Should help mitigate issues from users who look at motion review immediately after upgrading.
  • Use theme colors for "no preview found" divs. text-white would go unseen on the default theme in light mode.

Copy link

netlify bot commented Jun 7, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit f14d093
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/66628ba2dc9511000800ef73

@hawkeye217 hawkeye217 changed the title Prevent "undefined" from being displayed in searchParams string UI tweaks Jun 7, 2024
@NickM-27 NickM-27 merged commit 9f18101 into dev Jun 7, 2024
13 checks passed
@NickM-27 NickM-27 deleted the searchparams-fix branch June 7, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants