Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Statusbar rendering NaN% for unsupported GPUs #11655

Merged
merged 2 commits into from
May 30, 2024

Conversation

track0x1
Copy link
Contributor

@track0x1 track0x1 commented May 30, 2024

Noticed a small bug when using v0.14 on my RPI
image

Updated to completely hide GPU when unsupported instead of displaying NaN%

Copy link

netlify bot commented May 30, 2024

Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit b443721
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/6658ce91b28a48000878bb77

@NickM-27
Copy link
Sponsor Collaborator

I think it would be preferable to just hide the GPU% entirely

@track0x1
Copy link
Contributor Author

@NickM-27 Is there any value in showing the GPU at all in this scenario?

@NickM-27
Copy link
Sponsor Collaborator

right, that is what I mean. In the case that this GPU is reporting a non-readable value, just don't show anything for that GPU

@track0x1
Copy link
Contributor Author

@NickM-27 Updated PR to completely hide a GPU when unsupported

@NickM-27 NickM-27 merged commit 35946d3 into blakeblackshear:dev May 30, 2024
10 checks passed
@track0x1 track0x1 deleted the fix-nan-statusbar branch May 30, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants