Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve efficiency of log and metrics pages #11622

Merged
merged 4 commits into from
May 29, 2024
Merged

Improve efficiency of log and metrics pages #11622

merged 4 commits into from
May 29, 2024

Conversation

NickM-27
Copy link
Sponsor Collaborator

@NickM-27 NickM-27 commented May 29, 2024 •
edited
Loading

logs

  • only parse log lines once instead of each time the logs are appended
  • use different log page sizes depending on the device type
  • implement custom keyboard handlers for up / down keys on log page

metrics

  • manually insert 0 values on graphs when there is not enough natural data to fill the graph
  • don't expand the size of the stats list when new items come in

@netlify Netlify
Copy link

netlify bot commented May 29, 2024 •
edited
Loading

✅ Deploy Preview for frigate-docs canceled.

Name Link
🔨 Latest commit 1272b49
🔍 Latest deploy log https://app.netlify.com/sites/frigate-docs/deploys/665764aae16f8600083fcfd1

@NickM-27 NickM-27 merged commit 9245c5c into dev May 29, 2024
13 checks passed
@NickM-27 NickM-27 deleted the improve-log-metrics branch May 29, 2024 18:05
@xconverge
Copy link
Contributor

xconverge commented May 29, 2024 •
edited
Loading

0s were a good idea, LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hawkeye217 hawkeye217 hawkeye217 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@NickM-27 @xconverge @hawkeye217