Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live view aspect calculation bugfix #11545

Merged
merged 1 commit into from
May 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
save video dimensions in onLoadedData instead of onLoadedMetadata
  • Loading branch information
hawkeye217 committed May 26, 2024
commit 9835513cb81ecf108743dd805bc7e2fbc4746e50
6 changes: 4 additions & 2 deletions web/src/components/player/MsePlayer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -303,8 +303,10 @@ function MSEPlayer({
className={className}
playsInline
preload="auto"
onLoadedData={onPlaying}
onLoadedMetadata={handleLoadedMetadata}
onLoadedData={() => {
handleLoadedMetadata?.();
onPlaying?.();
}}
muted={!audioEnabled}
onError={() => {
if (wsRef.current) {
Expand Down